Make authz tuple deletion idempotent #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This detect if the error for deleting an object is caused by the tuple not existing, and if so, it discards the error since that's what we wanted. Thus making calls to the tuple deletion idempotent.
jhrozek
approved these changes
Jan 26, 2024
| @@ -255,7 +255,9 @@ func (a *ClientWrapper) Delete(ctx context.Context, user string, role Role, proj | |||
| Object: getProjectForTuple(project), | |||
| }, | |||
| }).Execute() | |||
| if err != nil { | |||
| if err != nil && strings.Contains(err.Error(), "cannot delete a tuple which does not exist") { | |||
There was a problem hiding this comment.
I assume there's no Error we could match using errors.Is ?
eleftherias
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This detect if the error for deleting an object is caused by the tuple
not existing, and if so, it discards the error since that's what we
wanted. Thus making calls to the tuple deletion idempotent.