Fix user deletion logic (first minder then keycloak) #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the user deletion logic to first delete a user and the relevant project information in minder and only after that doing the deletion in keycloak. This would address issues where the deletion gets interrupted thus leaving a user's project in minder whereas keycloak would provision an entirely new user.
eleftherias
approved these changes
Feb 8, 2024
dmjb
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the user deletion logic to first delete a user and the
relevant project information in minder and only after that doing the
deletion in keycloak. This would address issues where the deletion gets
interrupted thus leaving a user's project in minder whereas keycloak
would provision an entirely new user.