Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI table outputs for ruletype and profile #2327

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

rdimitrov
Copy link
Member

The following PR:

  • Removes the use of emojis in profile and remediation statuses - they were nice, but they always messed up the table rendering
image
  • Moved the Guidance column from the detailed profile status list table and put it in the ruletype get output
  • Added a Skipped text for remediations that skipped, prior to that it was empty looking and it looked like there could have been an error
  • Added a function that concatenates and wraps a string. Used that in the ruletype create/apply output so it renders on a smaller footprint.
  • Shortened some of the headers too because of that.

@rdimitrov rdimitrov requested a review from a team as a code owner February 9, 2024 13:35
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will miss the unicode blink, but these tables look much better (no annoying wrapping) on my laptop screen.

@rdimitrov rdimitrov merged commit d1aa640 into mindersec:main Feb 9, 2024
18 checks passed
@rdimitrov rdimitrov deleted the trim-cli branch February 9, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants