Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the Trusty options from the protobuf #2381

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Deprecate the Trusty options from the protobuf #2381

merged 3 commits into from
Feb 20, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Feb 19, 2024 •
edited
Loading

The following PR:

  • Removes the Trusty message from the proto
  • Logs a message saying if we'll be using a trusty endpoint we read from the environment or we default to our public instance
  • Updates the docker-compose endpoint. If this was intentional raise it and I'll revert it to the previous URL?

@rdimitrov rdimitrov requested a review from a team as a code owner February 19, 2024 17:26
@rdimitrov rdimitrov self-assigned this Feb 19, 2024
@rdimitrov rdimitrov mentioned this pull request Feb 19, 2024
Merged
@coveralls
Copy link

Coverage Status

coverage: 35.79% (+0.01%) from 35.779%
when pulling 7ab001e on rdimitrov:trusty
into 1e3fccd on stacklok:main.

@rdimitrov rdimitrov merged commit 54d28f8 into mindersec:main Feb 20, 2024
21 checks passed
@rdimitrov rdimitrov deleted the trusty branch February 20, 2024 10:50
evankanderson added a commit to evankanderson/minder that referenced this pull request Feb 21, 2024
@evankanderson
Revert proto changes from mindersec#2381, as they invalidated JSON st…
d77c2e3 
…ored in the Minder database
@evankanderson evankanderson mentioned this pull request Feb 21, 2024
Merged
evankanderson added a commit that referenced this pull request Feb 21, 2024
@evankanderson
Revert proto changes from #2381, as they invalidated JSON stored in t…
4109137 
…he Minder database (#2395)

* Revert proto changes from #2381, as they invalidated JSON stored in the Minder database

* Adjust buf settings to allow restoring removed messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

Assignees

@rdimitrov rdimitrov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdimitrov @coveralls @jhrozek