Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove token from builtin rules #2550

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

From what I can tell, the only built in rule is the passthough, which doesn't use the token.
Additionally, as we add more providers we can't assume that they will all have a token.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner March 7, 2024 16:27
@eleftherias eleftherias requested review from JAORMX and jhrozek March 7, 2024 16:27
@coveralls
Copy link

Coverage Status

coverage: 39.702% (-0.001%) from 39.703%
when pulling d55f51d on eleftherias:passthrough-no-token
into 04a8002 on stacklok:main.

@eleftherias eleftherias merged commit ed53d75 into mindersec:main Mar 7, 2024
21 checks passed
@eleftherias eleftherias deleted the passthrough-no-token branch March 7, 2024 18:25
dmjb pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants