Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ingestcache for artifacts #2603

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Disable ingestcache for artifacts #2603

merged 1 commit into from
Mar 12, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Mar 12, 2024

Summary

Due to the implementation of the artifact signature rule (lacking ingest
parameters) the ingestcache is caching tags that it shouldn't. While
this is fixed, let's disable caching for artifacts.

Related-to: #2600

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Due to the implementation of the artifact signature rule (lacking ingest
parameters) the ingestcache is caching tags that it shouldn't. While
this is fixed, let's disable caching for artifacts.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner March 12, 2024 14:45
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the issue is in the ingest cache, I suspect it's the EEA cache.

@jhrozek
Copy link
Contributor

jhrozek commented Mar 12, 2024

I'm not sure the issue is in the ingest cache, I suspect it's the EEA cache.

We can try merging this patch though and run the test a number of times if it helps..

@coveralls
Copy link

Coverage Status

coverage: 38.715% (+0.01%) from 38.701%
when pulling ab134d5 on ingestcache-artifacts
into af48a2c on main.

@JAORMX JAORMX merged commit a996b53 into main Mar 12, 2024
21 checks passed
@JAORMX JAORMX deleted the ingestcache-artifacts branch March 12, 2024 14:54
rdimitrov added a commit to rdimitrov/minder that referenced this pull request Mar 12, 2024
rdimitrov added a commit that referenced this pull request Mar 12, 2024
dmjb pushed a commit that referenced this pull request Mar 13, 2024
Due to the implementation of the artifact signature rule (lacking ingest
parameters) the ingestcache is caching tags that it shouldn't. While
this is fixed, let's disable caching for artifacts.

Signed-off-by: Juan Antonio Osorio <[email protected]>
dmjb pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants