Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project ID from entity context in rule creation #2636

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Mar 13, 2024

Refactor the code to only pass the project ID, not the whole context

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Refactor the code to only pass the project ID, not the whole context
@dmjb dmjb requested a review from a team as a code owner March 13, 2024 17:34
@coveralls
Copy link

coveralls commented Mar 13, 2024

Coverage Status

coverage: 40.576% (-0.003%) from 40.579%
when pulling 4818a43 on rule-intf-project-id
into c728815 on main.

@dmjb dmjb merged commit 9f0b994 into main Mar 13, 2024
20 checks passed
@dmjb dmjb deleted the rule-intf-project-id branch March 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants