Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EvalResultsService to ingress.yaml #2644

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

rdimitrov
Copy link
Member

Summary

Apparently I missed adding the EvalResultsService to our helm chart

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner March 14, 2024 09:36
@rdimitrov rdimitrov self-assigned this Mar 14, 2024
@coveralls
Copy link

coveralls commented Mar 14, 2024

Coverage Status

Changes unknown
when pulling ba3a46a on rdimitrov:ingress
into ** on stacklok:main**.

@rdimitrov rdimitrov merged commit 8035c66 into mindersec:main Mar 14, 2024
20 checks passed
@rdimitrov rdimitrov deleted the ingress branch March 14, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants