Revert "Move repository create to RepositoryService (#2632)" #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d68e8e6.
rdimitrov
approved these changes
Mar 14, 2024
dmjb
added a commit
that referenced
this pull request
Mar 14, 2024
dmjb
added a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit a0d83dc. As part of this PR, two bug fixes are introduced: 1) The repo create method now accepts a provider and sets the provider ID when creating the repo. 2) The API contract is deliberately changed for the RegisterRepository endpoint: errors during repo creation will result in a non-200 status code, and a partially-formed response is not returned as it was before.
dmjb
added a commit
that referenced
this pull request
Mar 14, 2024
dmjb
added a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit a0d83dc. As part of reapplying this commit, two bug fixes have been introduced: 1) Ensure that provider ID is set when creating the repository in the database. 2) Change the API response structure: do not return partially-filled responses when the request has failed.
dmjb
added a commit
that referenced
this pull request
Mar 15, 2024
This reverts commit a0d83dc. As part of reapplying this commit, two bug fixes have been introduced: 1) Ensure that provider ID is set when creating the repository in the database. 2) Change the API response structure: do not return partially-filled responses when the request has failed.
dmjb
added a commit
that referenced
this pull request
Mar 19, 2024
This reverts commit a0d83dc. As part of reapplying this commit, two bug fixes have been introduced: 1) Ensure that provider ID is set when creating the repository in the database. 2) Change the API response structure: do not return partially-filled responses when the request has failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The implementation didn't pass a provider name + ID and this broke staging
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: