Eval Status: Return repository UUID, populate entity info #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
previously approved these changes
Mar 21, 2024
|
Note that this will return the UUID of the repo in the |
jhrozek
reviewed
Mar 21, 2024
| @@ -278,6 +278,14 @@ func buildRuleEvaluationStatusFromDBEvaluation( | |||
| Msg("error converting severity will use defaults") | |||
| } | |||
|
|
|||
| entityInfo := map[string]string{} | |||
| if eval.Entity == db.EntitiesPullRequest { | |||
There was a problem hiding this comment.
Was this supposed to be db.EntitiesPullRequest or repository?
There was a problem hiding this comment.
Awesome catch, fixed.
Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
jhrozek
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change modifies the evaluation status response to return the repository UUID instead of the slug. It also populates the entity info map with the repository details.
/cc @jhrozek
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: