Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider classes to API #2762

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Add provider classes to API #2762

merged 1 commit into from
Mar 22, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Mar 22, 2024

Summary

Provided classes specify groups of configurations that work together for particular providers.

While the term was added to the DB and one part of the API, it wasn't hooked anywhere else.

This adds it where needed.

It also makes the db entry nullable, as the class is an optional parameter. That is,
we may have a provider that does not belong to any class... e.g. a self-configured provider.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner March 22, 2024 13:05
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nullable class seems a bit confusing, but it was an explicit change, so I assume you had a good reason, so I'll approve so you can go ahead.

@JAORMX JAORMX merged commit febf35f into main Mar 22, 2024
23 checks passed
@JAORMX JAORMX deleted the provider-classes branch March 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants