Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user facing error when credential is invalid #2772

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

This fixes a recently introduced bug, where we weren't showing the user a descriptive error message when they tried to register repos before enrolling a provider.
With this fix, the user now sees the message: cannot get credential for provider: did you run minder provider enroll? if they run minder repo register without having an enrolled provider.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner March 25, 2024 14:55
@coveralls
Copy link

Coverage Status

coverage: 47.564% (-0.003%) from 47.567%
when pulling 3623d9e on eleftherias:error-message-enroll
into c571835 on stacklok:main.

@eleftherias eleftherias merged commit eb025e1 into mindersec:main Mar 25, 2024
21 checks passed
@eleftherias eleftherias deleted the error-message-enroll branch March 25, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants