Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment on inferProvider call #2812

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Add comment on inferProvider call #2812

merged 1 commit into from
Mar 27, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Mar 27, 2024

Summary

This is to clarify the expectations on this function.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This is to clarify the expectations on this function.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX merged commit 8db7e06 into main Mar 27, 2024
20 checks passed
@JAORMX JAORMX deleted the comment-infer branch March 27, 2024 08:31
@coveralls
Copy link

Coverage Status

coverage: 47.741% (-0.01%) from 47.754%
when pulling 791030f on comment-infer
into f18a5b3 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants