Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm documentation about GitHub App secrets #2828

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Update helm README with instructions on github app secrets.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner March 27, 2024 12:40
@coveralls
Copy link

Coverage Status

coverage: 47.728% (+0.01%) from 47.716%
when pulling c01f854 on eleftherias:helm-github-app-docs
into 809687a on stacklok:main.

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why this disapperared from one of the renders

@JAORMX JAORMX merged commit 4d685c3 into mindersec:main Mar 27, 2024
21 checks passed
@eleftherias eleftherias deleted the helm-github-app-docs branch March 27, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants