Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a 0.2% natschannel_test flake with some forced scheduler sleeps #4841

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

evankanderson
Copy link
Member

Summary

I noticed natschannel_test failing in a CI run (which seem to run on a slower CPU than my MacBook). I was able to reproduce with -count 1000 with some background adversarial tasks. Putting in a forced scheduler transition (aka time.Sleep) after closing the subscriber seemed to prevent losing the third message (it was always the third message, which made me suspect the lines just before that publish).

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

go test -count 1000 ./internal/events/nats while running go test -count 2 ./... in parallel in another window.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner October 29, 2024 22:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11583782223

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 53.042%

Totals Coverage Status
Change from base Build 11579859014: 0.01%
Covered Lines: 13364
Relevant Lines: 25195

💛 - Coveralls

@evankanderson evankanderson merged commit a93a09d into mindersec:main Oct 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants