Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure coverage for pkg folder. #4845

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Oct 30, 2024

Summary

We recently moved a fair amount of code under from internal to the pkg folder. This fixes our CI configuration to measure coverage for that package as well.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manually tested.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Oct 30, 2024
@blkt blkt requested a review from a team as a code owner October 30, 2024 12:38
rdimitrov
rdimitrov previously approved these changes Oct 30, 2024
@coveralls
Copy link

coveralls commented Oct 30, 2024

Pull Request Test Coverage Report for Build 11600185493

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+2.2%) to 55.214%

Files with Coverage Reduction New Missed Lines %
internal/authz/authz.go 1 69.85%
Totals Coverage Status
Change from base Build 11590867124: 2.2%
Covered Lines: 15439
Relevant Lines: 27962

💛 - Coveralls

@rdimitrov
Copy link
Member

@blkt - oh, we might have to pin to certain paths otherwise we reduce the coverage by 14%

@rdimitrov rdimitrov dismissed their stale review October 30, 2024 13:04

Reduces coverage by 14%

@blkt blkt force-pushed the chore/measure-coverage-pkg-folder branch from a0aefed to f9c4f4d Compare October 30, 2024 16:39
@blkt
Copy link
Contributor Author

blkt commented Oct 30, 2024

@blkt - oh, we might have to pin to certain paths otherwise we reduce the coverage by 14%

Thanks for the ping, I should have fixed that.

By the way, we also have pkg/testkit that is not really a candidate for test coverage. Should we exclude that as well?

@blkt blkt force-pushed the chore/measure-coverage-pkg-folder branch from f9c4f4d to bedc3df Compare October 30, 2024 17:06
@evankanderson
Copy link
Member

@blkt - oh, we might have to pin to certain paths otherwise we reduce the coverage by 14%

Thanks for the ping, I should have fixed that.

By the way, we also have pkg/testkit that is not really a candidate for test coverage. Should we exclude that as well?

Probably, at least for now. Depending on how load-bearing that gets, we might want to include it, but let's keep it out for now.

We recently moved a fair amount of code under from `internal` to the
`pkg` folder. This fixes our CI configuration to measure coverage for
that package as well.
@blkt blkt force-pushed the chore/measure-coverage-pkg-folder branch from bedc3df to 4528cca Compare October 30, 2024 19:20
@evankanderson evankanderson merged commit 9a240c4 into main Oct 30, 2024
25 checks passed
@evankanderson evankanderson deleted the chore/measure-coverage-pkg-folder branch October 30, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants