Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the set bundle version query for the subscriptions table #4860

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR fixes a bug in the query. The query parameters were all mixed up and reused for different columns.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner November 1, 2024 11:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11628443776

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 55.222%

Files with Coverage Reduction New Missed Lines %
internal/authz/authz.go 1 69.85%
internal/eea/eea.go 2 73.73%
Totals Coverage Status
Change from base Build 11627525878: -0.004%
Covered Lines: 15534
Relevant Lines: 28130

💛 - Coveralls

@rdimitrov rdimitrov merged commit 94b802f into main Nov 1, 2024
25 of 26 checks passed
@rdimitrov rdimitrov deleted the fix-set-sub branch November 1, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants