Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for getting profile by name #4924

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix validation for getting profile by name #4924

merged 1 commit into from
Nov 8, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Nov 8, 2024

Summary

Fixes

Message: Error getting profile status
Details: Validation failed:
- Field 'name': value does not match regex pattern `^[A-Za-z][-[:word:]]*$`
Usage:
  minder profile status list [flags]

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner November 8, 2024 17:19
@rdimitrov rdimitrov self-assigned this Nov 8, 2024
@rdimitrov rdimitrov merged commit fee774b into main Nov 8, 2024
25 checks passed
@rdimitrov rdimitrov deleted the fix-profile branch November 8, 2024 17:22
@coveralls
Copy link

Coverage Status

coverage: 54.747%. remained the same
when pulling ed6a691 on fix-profile
into 01c526c on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants