Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate rule type alert during creation/update #4991

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Ensure early validation of the alert in ruletypes.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner November 18, 2024 16:40
@eleftherias eleftherias force-pushed the validate-ruletype-alert branch 3 times, most recently from 77ee89f to b826a64 Compare November 18, 2024 17:21
rdimitrov
rdimitrov previously approved these changes Nov 18, 2024
JAORMX
JAORMX previously approved these changes Nov 18, 2024
@eleftherias eleftherias dismissed stale reviews from JAORMX and rdimitrov via 7e3eeaf November 19, 2024 08:23
@eleftherias eleftherias force-pushed the validate-ruletype-alert branch from b826a64 to 7e3eeaf Compare November 19, 2024 08:23
@eleftherias eleftherias merged commit 39380da into mindersec:main Nov 19, 2024
23 of 24 checks passed
@eleftherias eleftherias deleted the validate-ruletype-alert branch November 19, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants