Fix the unit tests validating for required rule type fields #4998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
reviewed
Nov 19, 2024
pkg/profiles/validator_test.go
Outdated
| @@ -277,7 +277,7 @@ func makeProfile(opts ...func(*minderv1.Profile)) *minderv1.Profile { | |||
|
|
|||
| func loadRawRuleTypeDef() (json.RawMessage, error) { | |||
| // read rule type from disk and set it up as a fixture | |||
| f, err := os.Open("../../examples/rules-and-profiles/rule-types/github/branch_protection_allow_force_pushes.yaml") | |||
| f, err := os.Open("../../examples/rules-and-profiles/rule-types/github/branch_protection_allow_fork_syncing.yaml") | |||
There was a problem hiding this comment.
doesn't allowing fork sync also have the same issue? the branch is no longer mandatory.
There was a problem hiding this comment.
We are not relying on the branch field anymore, instead we use the allow_fork_syncing required field, i.e. https://github.com/mindersec/minder-rules-and-profiles/blob/5e9722f3472294e3b2cac6ffa115c36acef7aacd/rule-types/github/branch_protection_allow_fork_syncing.yaml#L41
There was a problem hiding this comment.
d'oh! that makes sense and somehow I missed it. Thanks for clarifying!
There was a problem hiding this comment.
Which is interesting because now it makes me wonder why this test worked before...
JAORMX
previously approved these changes
Nov 19, 2024
rdimitrov
force-pushed
the
fix-required
branch
from
118f8eb to
f863e6d
Compare
Signed-off-by: Radoslav Dimitrov <[email protected]>
rdimitrov
force-pushed
the
fix-required
branch
from
f863e6d to
8d84552
Compare
JAORMX
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following PR fixes the unit tests validating for required rule type fields
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: