Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the rest of the handlers for data sources #5080

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Nov 28, 2024

Summary

The following PR implements the rest of the handlers for data sources including the unit tests for all handlers.

Fixes: #5042

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner November 28, 2024 14:25
@rdimitrov rdimitrov self-assigned this Nov 28, 2024
@rdimitrov rdimitrov merged commit 531313b into main Nov 28, 2024
27 checks passed
@rdimitrov rdimitrov deleted the add-handlers branch November 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call Data Sources service in control plane
2 participants