Set required proto fields in repositories #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleftherias
force-pushed
the
openapi-repos-required
branch
from
cd497d0 to
f6cca2f
Compare
eleftherias
force-pushed
the
openapi-repos-required
branch
from
f6cca2f to
265ed7c
Compare
JAORMX
reviewed
Nov 29, 2024
| @@ -1230,7 +1250,8 @@ message UpstreamRepositoryRef { | |||
| pattern: "^[-.[:alnum:]_]+$", | |||
| max_len: 200, | |||
| }, | |||
| (buf.validate.field).ignore = IGNORE_IF_DEFAULT_VALUE | |||
| (buf.validate.field).ignore = IGNORE_IF_DEFAULT_VALUE, | |||
| (google.api.field_behavior) = REQUIRED | |||
There was a problem hiding this comment.
I'm confused by this. We say "IGNORE_IF_DEFAULT_VALUE" then check for optional?
There was a problem hiding this comment.
I'm confident that the IGNORE_IF_DEFAULT_VALUE isn't correct because when processing the request we fail if name is unset. I would like to do some additional testing and remove that annotation in a different PR.
JAORMX
reviewed
Nov 29, 2024
JAORMX
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref #4952
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: