Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set required proto fields for profiles #5099

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Ref #4952

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner November 29, 2024 16:56
@coveralls
Copy link

Coverage Status

coverage: 55.163% (+0.01%) from 55.153%
when pulling b7c2360 on eleftherias:openapi-profile
into 76bb3a6 on mindersec:main.

JAORMX
JAORMX previously approved these changes Nov 29, 2024
puerco
puerco previously approved these changes Nov 29, 2024
@eleftherias eleftherias dismissed stale reviews from puerco and JAORMX via 74a436f December 2, 2024 08:14
@eleftherias eleftherias merged commit 7d21b20 into mindersec:main Dec 2, 2024
24 of 25 checks passed
@eleftherias eleftherias deleted the openapi-profile branch December 2, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants