Enable CreateDataSource and UpdateDataSource API calls to complete #5101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces two changes to allow the
CreateDataSource()
andUpdateDataSource()
API calls to run their handlers. Currently, they fail early because 1) the proto validation is looking for the data source UUID (when it does not exist yet) and 2) the context cannot be extracted from the request, for example:This fixes the proto validation and the error
Error extracting context from request
by:IGNORE_IF_DEFAULT_VALUE
to the data source proto definition in 44c23bbGetContext()
methods to the update/create data source request payload types to satisfy and allow the payloads to work withgetProjectIDFromContext()
(in 1d90076)Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: