Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PR check action on synchronize #5140

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Run PR check action on synchronize #5140

merged 1 commit into from
Dec 5, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Dec 5, 2024

When reusing this action elsewhere, I noticed that its status would be cleared if additional commits were pushed to the PR branch. Triggering on the synchronize event ensures that it will be checked on subsequent commits.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

When reusing this action elsewhere, I noticed that its status would be
cleared if additional commits were pushed to the PR branch. Triggering
on the synchronize event ensures that it will be checked on subsequent
commits.
@dmjb dmjb requested a review from a team as a code owner December 5, 2024 11:24
@coveralls
Copy link

Coverage Status

coverage: 55.187% (-0.007%) from 55.194%
when pulling f98ceaa on fix-pr-check-action
into c2d9126 on main.

@JAORMX JAORMX merged commit d60cba7 into main Dec 5, 2024
27 of 28 checks passed
@JAORMX JAORMX deleted the fix-pr-check-action branch December 5, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants