Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle synchronize events for pull requests in github #5141

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 5, 2024

Signed-off-by: Juan Antonio Osorio [email protected]

Summary

We should just try to re-evaluate the PR instead of creating a new
entry.

Fixes #5139

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We should just try to re-evaluate the PR instead of creating a new
entry.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner December 5, 2024 12:10
rdimitrov
rdimitrov previously approved these changes Dec 5, 2024
@rdimitrov
Copy link
Member

Perhaps the tests need to be updated 👍

@rdimitrov rdimitrov dismissed their stale review December 5, 2024 12:25

Tests need updating

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from rdimitrov December 5, 2024 13:23
@JAORMX JAORMX merged commit 56ff5e3 into mindersec:main Dec 5, 2024
26 checks passed
@JAORMX JAORMX deleted the handle-synchronize-gh-pr branch December 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate key error when updating PR
3 participants