Promote pull request properties #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source and target PR information, as well as the upstream URL have been promoted to top level properties. The GitLab provider now fills these in by default and uses them to populate the PR protobuf. The GitHub provider fills in the properties in, but currently does not leverage them; this will be done after some rollout time. Signed-off-by: Juan Antonio Osorio <[email protected]>
rdimitrov
previously approved these changes
Dec 10, 2024
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
rdimitrov
approved these changes
Dec 10, 2024
teodor-yanev
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The source and target PR information, as well as the upstream URL have
been promoted to top level properties.
The GitLab provider now fills these in by default and uses them to
populate the PR protobuf.
The GitHub provider fills in the properties in, but currently does not
leverage them; this will be done after some rollout time.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: