Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enabling repo auto registration for providers #5171

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix enabling repo auto registration for providers #5171

merged 1 commit into from
Dec 10, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR fixes enabling repo auto registration.

It got broken because of the recent proto validations we added, but this was hidden because we were also ignoring the errors and were always returning a message indicating a successful result.

Fixes #5166

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner December 10, 2024 10:49
@rdimitrov rdimitrov self-assigned this Dec 10, 2024
@coveralls
Copy link

coveralls commented Dec 10, 2024

Coverage Status

coverage: 55.308% (-0.005%) from 55.313%
when pulling 00fe0bc on fix-auto
into ad08eec on main.

@rdimitrov rdimitrov merged commit dc1d2ef into main Dec 10, 2024
26 checks passed
@rdimitrov rdimitrov deleted the fix-auto branch December 10, 2024 11:16
@evankanderson
Copy link
Member

Should we also allow an empty version string to mean "v1" for compatibility with existing clients?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto repo registration is not working
4 participants