Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the project flag for minder datasource #5189

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

rdimitrov
Copy link
Member

Summary

The following PR registers the project flag for the minder datasource CLI command

Fixes #5187

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner December 12, 2024 13:26
Copy link
Contributor

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank youuuu 🙏

@rdimitrov rdimitrov merged commit b69d87d into main Dec 12, 2024
23 of 24 checks passed
@rdimitrov rdimitrov deleted the fix-ds-project branch December 12, 2024 13:29
@coveralls
Copy link

Coverage Status

coverage: 55.352% (-0.003%) from 55.355%
when pulling 9f38ad9 on fix-ds-project
into 8502c32 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The minder datasource apply subcommand does not take a project
4 participants