Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor introduce recording storage #274

Merged

Conversation

betaboon
Copy link
Contributor

as discussed here an implementation for a dedicated request-recorder class.

@betaboon betaboon force-pushed the refactor-introduce-recording-storage branch 2 times, most recently from 0da3eeb to cf8450f Compare November 25, 2024 21:10
@betaboon
Copy link
Contributor Author

also included a small fix in the ci-configuration which led to an ugly space in the ci-status :P

@coveralls
Copy link

Coverage Status

coverage: 98.682% (-0.3%) from 99.025%
when pulling f3872d6 on betaboon:refactor-introduce-recording-storage
into a5b5e34 on mindflayer:main.

@coveralls
Copy link

coveralls commented Nov 25, 2024

Coverage Status

coverage: 98.682% (-0.3%) from 99.025%
when pulling 1ba5b07 on betaboon:refactor-introduce-recording-storage
into a5b5e34 on mindflayer:main.

@mindflayer
Copy link
Owner

mindflayer commented Nov 26, 2024

Could you please sort out the three FIXMEs? I am still reviewing it, but I don't see anything serious.

mocket/recording.py Outdated Show resolved Hide resolved
@betaboon betaboon force-pushed the refactor-introduce-recording-storage branch from f3872d6 to 435113c Compare November 26, 2024 07:03
@betaboon betaboon force-pushed the refactor-introduce-recording-storage branch from 435113c to 1ba5b07 Compare November 26, 2024 08:29
@mindflayer mindflayer merged commit e529319 into mindflayer:main Nov 26, 2024
8 of 9 checks passed
@mindflayer
Copy link
Owner

mindflayer commented Nov 26, 2024

Amazing job, @betaboon, many thanks!

@betaboon
Copy link
Contributor Author

@mindflayer I'm currently working on doing the last thing that i mentioned:

refactoring Entry, Request, Response.

until that is done i would hold of from instructing people to replace the recorder-class (as in those other PRs)

maybe we should somehow make the replacing of recorder-class a public api when we're ready?

@betaboon betaboon deleted the refactor-introduce-recording-storage branch November 26, 2024 10:12
@mindflayer
Copy link
Owner

mindflayer commented Nov 26, 2024

maybe we should somehow make the replacing of recorder-class a public api when we're ready?

Getter/setter on top of _record_storage, a test, and a few lines of documentation, would do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants