-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor introduce recording storage #274
Refactor introduce recording storage #274
Conversation
0da3eeb
to
cf8450f
Compare
also included a small fix in the ci-configuration which led to an ugly space in the ci-status :P |
Could you please sort out the three FIXMEs? I am still reviewing it, but I don't see anything serious. |
f3872d6
to
435113c
Compare
435113c
to
1ba5b07
Compare
Quality Gate passedIssues Measures |
Amazing job, @betaboon, many thanks! |
@mindflayer I'm currently working on doing the last thing that i mentioned: refactoring Entry, Request, Response. until that is done i would hold of from instructing people to replace the recorder-class (as in those other PRs) maybe we should somehow make the replacing of recorder-class a public api when we're ready? |
Getter/setter on top of |
as discussed here an implementation for a dedicated request-recorder class.