Add configuration option for automatically marking entry as read when viewed #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you are adding a new global option. But it would be better to have this option for each user and make it configurable in the settings page (same as other options related to entries). |
xl-s
force-pushed
the
config-read-on-view
branch
from
dc28c03 to
dc9586f
Compare
|
Thanks for the feedback, I've modified the change to use a user setting instead. |
This was referenced Apr 26, 2022
1 task
|
I'd love to see this merged. Is there anything blocking it? |
xl-s
force-pushed
the
config-read-on-view
branch
3 times, most recently
from
eb18250 to
4e4bd13
Compare
xl-s
force-pushed
the
config-read-on-view
branch
from
4e4bd13 to
739d4c4
Compare
|
I would love this feature! Any reason why it isn't merged yet? |
fguillot
force-pushed
the
config-read-on-view
branch
from
739d4c4 to
09f21a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries are immediately mark as read when they are viewed or when 'external link' is clicked. It would be nice to have an option which allows users manual control over when an entry is marked as read.
Do you follow the guidelines?