🐛 Deal with invalid date inputs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to using date picker elements, an invalid date can only occur if a user types in one of the fields, and even then some possible failure modes can't occur, e.g. trying to type a day above 31 or month above 12 will not work. Only typing an invalid day for a shorter month, e.g. 31st November, will cause an error. In this case the date picker's value is just the empty string rather than what is visible in the date picker. The other invalid situation is when the start date is after the end date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to using date picker elements, an invalid date can only occur if a user types in one of the fields, and even then some possible failure modes can't occur, e.g. trying to type a day above 31 or month above 12 will not work. Only typing an invalid day for a shorter month, e.g. 31st November, will cause an error. In this case the date picker's value is just the empty string rather than what is visible in the date picker. The other invalid situation is when the start date is after the end date.
This resolves #5