Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New kubectl minio flags #1171

Merged
merged 3 commits into from
Apr 1, 2024
Merged

New kubectl minio flags #1171

merged 3 commits into from
Apr 1, 2024

Conversation

@feorlen feorlen marked this pull request as draft March 26, 2024 20:05
@feorlen feorlen self-assigned this Mar 26, 2024
@feorlen
Copy link
Collaborator Author

feorlen commented Mar 26, 2024

@allanrogerr a question about additional detail for kubectl minio tenant create --volumes-per-server:

The existing text for --volumes has a lot of detail about the PVCs and PVs.

How does this work with --volumes-per-server and what should be said about it? Limitations? Performance considerations? Something else?

@feorlen feorlen marked this pull request as ready for review March 29, 2024 19:18
@allanrogerr
Copy link
Contributor

Responded offline.

Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we move required flags to the top of the syntax list.
Couple of other questions or suggestions to consider.

But, in general, this is fine for what's about to be deprecated anyway.
LGTM

@feorlen feorlen merged commit b0ab2be into main Apr 1, 2024
@feorlen feorlen deleted the DOCS-1129-kubectl branch April 1, 2024 22:14
feorlen added a commit that referenced this pull request Apr 2, 2024
Oops did not type something correctly, this should have been included in
#1171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants