Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mc: Vendorize minio-go this brings in streaming support. #2203

Merged
merged 1 commit into from
Jul 6, 2017
Merged

mc: Vendorize minio-go this brings in streaming support. #2203

merged 1 commit into from
Jul 6, 2017

Conversation

harshavardhana
Copy link
Member

This PR brings following changes

  • Brings streaming support for mc uploads.
  • Brings support for copying objects upto 5TiB
    as a consequence of ComposeObject implementation
    in minio-go.

@codecov-io
Copy link

codecov-io commented Jul 5, 2017 •
edited
Loading

Codecov Report

Merging #2203 into master will decrease coverage by 0.04%.
The diff coverage is 23.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2203      +/-   ##
=========================================
- Coverage    9.07%   9.03%   -0.05%     
=========================================
  Files          93      93              
  Lines        6908    6899       -9     
=========================================
- Hits          627     623       -4     
+ Misses       6152    6149       -3     
+ Partials      129     127       -2
Impacted Files Coverage Δ
cmd/globals.go 0% <ø> (ø) ⬆️
cmd/common-methods.go 0% <0%> (ø) ⬆️
pkg/hookreader/hookreader.go 25% <0%> (-16.67%) ⬇️
cmd/client-s3.go 13.86% <10%> (-0.05%) ⬇️
cmd/client-fs.go 29.38% <54.54%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8391a69...e68865a. Read the comment docs.

vadmeste
vadmeste reviewed Jul 5, 2017
View reviewed changes
cmd/common-methods.go
@@ -136,8 +136,8 @@ func uploadSourceToTargetURL(urls URLs, progress io.Reader) URLs {
targetURL := urls.TargetContent.URL
length := urls.SourceContent.Size

// Optimize for server side copy if object is <= 5GiB and the host is same.
if length <= globalMaximumPutSize && sourceAlias == targetAlias {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing length <= globalMaximumPutSize because minio-go already does that ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now minio-go supports copyObject upto 5TiB // cc @donatello

vadmeste
vadmeste previously approved these changes Jul 5, 2017
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested (resume download and copy)

@donatello
Copy link
Member

PR minio/minio-go#741 also needs to be in minio-go before it is vendored here to be sure that there are no known bugs.

@harshavardhana
Copy link
Member Author

PR minio/minio-go#741 also needs to be in minio-go before it is vendored here to be sure that there are no known bugs.

Yes waiting on two PRs to be merged

@harshavardhana
Copy link
Member Author

PR is updated @donatello @krishnasrinivas with the latest minio-go.

krishnasrinivas
krishnasrinivas previously approved these changes Jul 6, 2017
View reviewed changes
@harshavardhana
mc: Vendorize minio-go this brings in streaming support.
e68865a 
This PR brings following changes

- Brings streaming support for mc uploads.
- Brings support for copying objects upto 5TiB
  as a consequence of ComposeObject implementation
  in minio-go.
vadmeste
vadmeste approved these changes Jul 6, 2017
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vadmeste vadmeste merged commit 5c135d2 into minio:master Jul 6, 2017
@harshavardhana harshavardhana deleted the streaming branch July 6, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnasrinivas krishnasrinivas krishnasrinivas approved these changes

@vadmeste vadmeste vadmeste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshavardhana @codecov-io @donatello @vadmeste @krishnasrinivas