Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to batch-expire jobs #4677

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Add support to batch-expire jobs #4677

merged 1 commit into from
Dec 2, 2023

Conversation

krisis
Copy link
Member

@krisis krisis commented Sep 7, 2023 •
edited
Loading

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Add support for batch-expire

Motivation and Context

minio/minio#17946
Depends on: minio/madmin-go#239

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@krisis krisis force-pushed the batch-expire branch 2 times, most recently from cc816ae to d1c3934 Compare October 16, 2023 23:26
@krisis krisis marked this pull request as ready for review October 23, 2023 20:30
@krisis krisis mentioned this pull request Oct 23, 2023
Merged
11 tasks
@krisis krisis force-pushed the batch-expire branch 2 times, most recently from 818176e to 81b004f Compare November 10, 2023 00:03
shtripat
shtripat approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minio-trusted minio-trusted merged commit d920e2b into minio:master Dec 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minio-trusted minio-trusted minio-trusted approved these changes

@shtripat shtripat shtripat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krisis @shtripat @minio-trusted