Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ILM add validation to accept with noncurrent-transition-newer set #4732

Conversation

jinapurapu
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Updates validation to accept lifecycle options with noncurrent-transition-newer set

Motivation and Context

Trying to set ILM rule using noncurrent-transition-newer flag triggered validation which was only checking transitionDays

jillii ~/mc [(HEAD detached at upstream/master)] $ ./mc ilm rule add --noncurrent-transition-newer 3 --noncurrent-transition-tier "TESTA" minio/jilltest 
mc: <ERROR> Unable to generate new lifecycle rules for the input: noncurrentversion-transition-days must be set.

How to test this PR?

Try adding a new ILM rule using the --noncurrent-transition-newer flag

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@jinapurapu jinapurapu self-assigned this Oct 25, 2023
cmd/ilm/options.go Outdated Show resolved Hide resolved
@jinapurapu jinapurapu force-pushed the add_newer_noncurrent_version_validation branch from c985faa to b39a492 Compare October 26, 2023 21:19
@krisis
Copy link
Member

krisis commented Oct 26, 2023

@jinapurapu MinIO doesn't yet support NewerNoncurrentVersions with tiering. It is only available for NoncurrentVersionExpiration.

@jinapurapu jinapurapu closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants