Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken mc anonymous get/get-json #4791

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

subnix
Copy link
Contributor

@subnix subnix commented Dec 14, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

mc anonymous get/get-json have been broken by PR #4745, because it tries to guess an operation and fails before finding one. So we can avoid this by explicit operation handling.

How to test this PR?

mc anonymous get [target]
mc anonymous get-json [target]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@subnix
Copy link
Contributor Author

subnix commented Dec 14, 2023

Oh, now I see fix f78f391, but it hasn't been completely fixed. It doesn't work if file/directory named TARGET exists.

mkdir -p play/upload
mc anonymous get play/upload

@harshavardhana harshavardhana merged commit c0462e6 into minio:master Dec 15, 2023
5 checks passed
@subnix subnix deleted the fix/anonymous-get branch January 16, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants