Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RemoveObjectsWithResult() for detailed delete results #1456

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Feb 20, 2021

Using this API will make it easier to get the delete marker version id
after removing an object in a versioned bucket.

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you name API as RemoveObjectsWithResult() - we can avoid breaking change and making v8 since we are not there yet in terms of overhaul of the SDK API.

@harshavardhana
Copy link
Member

@vadmeste is there anything that you need help on this PR?

@vadmeste vadmeste changed the title [Breaking API] RemoveObjects() to return delete-marker & delete-marker-version-id Add RemoveObjectsWithResult() to return delete-marker & delete-marker-version-id Nov 25, 2021
…-version-id

Using this API will make it easier to get the delete marker version id
after removing an object in a versioned bucket.
@vadmeste
Copy link
Member Author

@vadmeste is there anything that you need help on this PR?

Done. Functional tests will work now with the latest MinIO release.

@harshavardhana harshavardhana changed the title Add RemoveObjectsWithResult() to return delete-marker & delete-marker-version-id Add RemoveObjectsWithResult() for detailed delete results Dec 7, 2021
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit a566788 into minio:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants