Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert LDAP/JWT Identity from query to form body #1688

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

harshavardhana
Copy link
Member

HTTP calls get logged through proxies, avoid
sensitive data getting logged by using request
body instead of query params.

HTTP calls get logged through proxies, avoid
sensitive data getting logged by using request
body instead of query params.
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit a5dc7d2 into minio:master Aug 29, 2022
@harshavardhana harshavardhana deleted the iam-sts branch August 29, 2022 12:10
@a1466d44-d3dc-4c0b-90c7-315b088731d7

Quick question from the uninformed: Is this automagicaly going to work on the minio service side as well, because I cant find a matching change there?

@harshavardhana
Copy link
Member Author

Quick question from the uninformed: Is this automagicaly going to work on the minio service side as well, because I cant find a matching change there?

Yes it will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants