-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PutObject checksums #1690
Merged
harshavardhana
merged 4 commits into
minio:master
from
klauspost:add-putobject-checksums
Sep 16, 2022
Merged
Add PutObject checksums #1690
harshavardhana
merged 4 commits into
minio:master
from
klauspost:add-putobject-checksums
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single part, checksums must be done manually for now until we have trailing headers. For multipart we add CRC32C if we don't already send a checksum and we read the content before sending. Also serves as test for minio/minio#15433 - but should be backwards compatible. Needs to be tested against S3, only implemented from docs.
2 tasks
1 task
harshavardhana
approved these changes
Sep 2, 2022
vadmeste
reviewed
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
klauspost
commented
Sep 6, 2022
harshavardhana
approved these changes
Sep 7, 2022
Looks like a nil map crash
|
vadmeste
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ping @harshavardhana |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single part, checksums must be done manually for now until we have trailing headers.
For multipart we add CRC32C if we don't already send a checksum and we read the content before sending.
Also serves as test for minio/minio#15433 - but should be backwards compatible.
AWS S3 tests
Single Part
Multipart
Seems we are compatible with S3.