Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken unmarshal metadata map due to XML changes #1698

Merged
merged 1 commit into from
Sep 24, 2022
Merged

fix: broken unmarshal metadata map due to XML changes #1698

merged 1 commit into from
Sep 24, 2022

Conversation

harshavardhana
Copy link
Member

No description provided.

@harshavardhana
Copy link
Member Author

Since this PR change

commit 8902561f3cdc8f606b8cec208b02d5ff1df3c524
Author: Harshavardhana <[email protected]>
Date:   Tue Aug 23 17:04:11 2022 -0700

    use new xxml for XML responses to support rare control characters (#15511)
    
    use new xxml/XML responses to support rare control characters
    
    fixes #15023

ListObjects with metadata is not working correctly due to XML marshaling changes in Go -
make appropriate changes in mc to handle this change.

@harshavardhana
Copy link
Member Author

@balamurugana this change is needed in python and java SDK as well.

@harshavardhana harshavardhana requested review from poornas and balamurugana and removed request for vadmeste September 24, 2022 04:19
@harshavardhana harshavardhana merged commit 92aabc2 into minio:master Sep 24, 2022
@harshavardhana harshavardhana deleted the xml-change branch September 24, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@balamurugana balamurugana Awaiting requested review from balamurugana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshavardhana @poornas