fail properly while parsing duplicate tags #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
tags
branch
from
0f899e1 to
2c72ed1
Compare
klauspost
reviewed
Sep 28, 2022
harshavardhana
force-pushed
the
tags
branch
from
2c72ed1 to
5fe476a
Compare
harshavardhana
force-pushed
the
tags
branch
2 times, most recently
from
4589f2f to
c85be75
Compare
klauspost
reviewed
Sep 28, 2022
harshavardhana
force-pushed
the
tags
branch
from
c85be75 to
d5612f0
Compare
AWS S3 API expects duplicate keys to be rejected, due to our usage of url.ParseQuery() this was skipped since url query parser simply appends duplicate keys as key with multiple values, this is not desirable. Add more input validation and restrictions as per AWS S3 API.
harshavardhana
force-pushed
the
tags
branch
from
d5612f0 to
bbf6e32
Compare
klauspost
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS S3 API expects duplicate keys to be rejected,
due to our usage of url.ParseQuery() this was skipped
since URL query parser simply appends duplicate keys
as key with multiple values, this is not desirable.
Add more input validation and restrictions as per
AWS S3 API.