Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use provided sha256 hasher #1749

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

klauspost
Copy link
Contributor

Use client provided hasher for SHA256 signatures.

By default this is "minio/sha256-simd" or "crypto/sha256" for FIPS.

Bonus: Skip tests if env var is missing.

Use client provided hasher for SHA256 signatures.

By default this is "minio/sha256-simd" or "crypto/sha256" for FIPS.

Bonus: Skip tests if env var is missing.
@vadmeste
Copy link
Member

@klauspost looks like this needs one more fix

@klauspost klauspost requested a review from vadmeste January 12, 2023 13:41
@klauspost klauspost requested a review from vadmeste January 12, 2023 14:58
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants