fix: GCS endpoint validation to allow ports

[ammarhusain-sol]

fix: Fixed the endpoint validation issue for GCS if port number is added to the URL

[harshavardhana]

why do you add a port number? for perfectly simple URL like

storage.googleapis.com

?

[ammarhusain-sol]

In the case of a URL with added port number, the validation check fails even though the endpoint is storage.googleapis.com

[harshavardhana]

In the case of a URL with added port number, the validation check fails even though the endpoint is storage.googleapis.com

yes but why add the port, http is port 80 and https is port 443, why specify it again?

[ammarhusain-sol]

You are saying by default http and https requests are handled through 80 and 443 so why do we have to mention it explicitly that is what you are asking right?
The reason I have added this here is that restricting the users not to add port number in the request endpoint I thought of as a limitation so I added also I faced this problem only for the GCS endpoint alone not for the AWS S3 endpoint, that is another reason why I added it.

[harshavardhana]

You are saying by default http and https requests are handled through 80 and 443 so why do we have to mention it explicitly that is what you are asking right?
The reason I have added this here is that restricting the users not to add port number in the request endpoint I thought of as a limitation so I added also I faced this problem only for the GCS endpoint alone not for the AWS S3 endpoint, that is another reason why I added it.

I added review comments, we can take it in with the requested changes.

[ammarhusain-sol]

@harshavardhana I made the changes.

[harshavardhana]

@harshavardhana I made the changes.

Please run gofumpt and goimports

[vadmeste]

LGTM

[klauspost]

Test is failing:

2024-07-11T18:04:06.2797859Z ##[error]    utils_test.go:136: Test 18: Expected to fail with <ERROR> "Google Cloud Storage endpoint should be 'storage.googleapis.com'.", but passed instead
2024-07-11T18:04:06.2808886Z --- FAIL: TestGetEndpointURL (0.00s)

[ammarhusain-sol]

@klauspost found the issue in test18 it has been written that the GCP endpoint with a port number should fail, since we made that change it is not failing.
Thanks for sharing

[harshavardhana]

FWIW I fixed it locally, waiting for the build will be merged.