Allow status code 200 for removeBucketPolicy #2047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe Hetzner should be S3 compatible instead? |
|
I guess. Sorry, didn't read the specs. I opened a ticket with Hetzner now see what they say. I know is the AWS specs but does it really make a difference? |
|
We generally don't add workarounds for third party S3 compatibility. We would end up with an unmaintainable mess. When the spec is unclear or AWS behaves differently than the spec (yes, that happens more often than you think), we can make exceptions. Keeping it open in case my colleagues don't agree on this. |
|
Fair enough. I wait for Hetzner''s answer for now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Hetzner Object Storage, and they return a status code of 200 on successfully deleting bucket policy.
This pull request fixes the issue of getting an error even through the policy was successfully deleted.
The error handling was introduced here
#1609
Kind regards