Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list: Don't send incomplete uploads info with err #556

Merged
merged 1 commit into from
Nov 27, 2016

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Nov 27, 2016

Incomplete Uploads List API continues to send object information even
when an error is encountered. This commit fixes this behavior with
sending only err in the incomplete upload list.

@harshavardhana
Copy link
Member

Commit message is incorrect here we are still sending err on object channel ?

@vadmeste
Copy link
Member Author

Commit message is incorrect here we are still sending err on object channel ?

yes.. I meant avoid sending object info when error is encountered, good enough?

@harshavardhana
Copy link
Member

yes.. I meant avoid sending object info when error is encountered, good enough?

Yes you need to update the commit message. Currently it says something else.

@vadmeste vadmeste force-pushed the list_multipart_error_abort branch from d0f7f14 to bf60cb8 Compare November 27, 2016 18:45
@harshavardhana
Copy link
Member

Also @vadmeste can you format the commit message so that the commit line is of a set length and wrapping into next line. Perhaps a good measurement is to 50 characters at max on the top line and explain the rest in the body.

Incomplete Uploads List API continues to send object information even
when an error is encountered. This commit fixes this behavior with
sending only err in the incomplete upload list.
@vadmeste vadmeste force-pushed the list_multipart_error_abort branch from bf60cb8 to 15cd6a0 Compare November 27, 2016 19:02
@vadmeste
Copy link
Member Author

Also @vadmeste can you format the commit message so that the commit line is of a set length and wrapping into next line. Perhaps a good measurement is to 50 characters at max on the top line and explain the rest in the body.

Done. I saw that VIM gives that 50 columns hint when writing the commit message, however, I wonder how it will be always possible to write a commit title with 50 characters only.

@harshavardhana
Copy link
Member

harshavardhana commented Nov 27, 2016

Done. I saw that VIM gives that 50 columns hint when writing the commit message, however, I wonder how it will be always possible to write a commit title with 50 characters only.

It should be, title should be precise and small. To explain the rest move to the body.

@harshavardhana harshavardhana changed the title Avoid sending the error and the object information in the list incomp… list: Don't send incomplete uploads info with err Nov 27, 2016
@harshavardhana harshavardhana merged commit 95231ce into minio:master Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants