Move s3 signature v4 and v2 to a separate pkg #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
force-pushed
the
use_s3_signer_pkg
branch
2 times, most recently
from
aff8cb6 to
14e7b4f
Compare
harshavardhana
requested changes
Dec 10, 2016
| @@ -32,6 +35,17 @@ var supportedGetReqParams = map[string]struct{}{ | |||
| "response-content-disposition": {}, | |||
| } | |||
|
|
|||
| // getCredential - generates Credential field for post policy | |||
| func getCredential(accessKeyID, location string, t time.Time) string { | |||
There was a problem hiding this comment.
Move this to signer package as well s3signer.GetCredential
There was a problem hiding this comment.
Move this to signer package as well s3signer.GetCredential
Done
vadmeste
force-pushed
the
use_s3_signer_pkg
branch
from
14e7b4f to
beaa71d
Compare
harshavardhana
approved these changes
Dec 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid code duplication by moving code related to signture v2 and v4 in a different location