Introduce client level custom settings with S3TransferAccelerate() API. #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your review is needed @abperiasamy |
krisis
reviewed
Dec 29, 2016
| @@ -206,8 +209,7 @@ func privateNew(endpoint, accessKeyID, secretAccessKey string, secure bool) (*Cl | |||
|
|
|||
| // SetAppInfo - add application details to user agent. | |||
| func (c *Client) SetAppInfo(appName string, appVersion string) { | |||
| // if app name and version is not set, we do not a new user | |||
| // agent. | |||
| // if app name and version is not set, we do not a new user agent. | |||
There was a problem hiding this comment.
nit: s/we do not a new /we do not set a new
| @@ -672,9 +685,17 @@ func (c Client) makeTargetURL(bucketName, objectName, bucketLocation string, que | |||
| host := c.endpointURL.Host | |||
| // For Amazon S3 endpoint, try to fetch location based endpoint. | |||
| if s3utils.IsAmazonEndpoint(c.endpointURL) { | |||
| // Fetch new host based on the bucket location. | |||
| host = getS3Endpoint(bucketLocation) | |||
| if c.isS3AccelerateEndpoint { | |||
There was a problem hiding this comment.
To support S3 transfer acceleration shouldn't minio-go validate the conditions mentioned in the docs?
http://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration.html#transfer-acceleration-requirements
e.g, this feature is applicable only on buckets where transfer acceleration is configured.
There was a problem hiding this comment.
We don't need to validate them, it is up-to the user if they have enabled it from AWS console this would work.
We don't need to introduce a new API.
harshavardhana
force-pushed
the
support-s3-transfer
branch
4 times, most recently
from
ca63123 to
3f0a373
Compare
harshavardhana
force-pushed
the
support-s3-transfer
branch
from
3f0a373 to
4186f8c
Compare
harshavardhana
force-pushed
the
support-s3-transfer
branch
from
4186f8c to
bfd2bb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #585