#593 fix GetObject seek to support http.ServeContent #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
// cc @vadmeste review this. |
|
@hexadecy, I am going to write extensive unit tests and try to cover all possible cases and send your a PR, this is a critical part. |
|
@hexadecy, I've sent a PR with the needed unit test enhancements, can you merge it ? |
Enhance unit test for object Seeker
harshavardhana
approved these changes
Feb 3, 2017
vadmeste
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested a lot with videogular player with mp3 and ogg files stored on s3.