Make sure to pass the contentBody to NewRequest appropriately. #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
nop-closer
branch
2 times, most recently
from
8d4ac4c to
79cb9b6
Compare
vadmeste
reviewed
Feb 17, 2017
api-put-object.go
Outdated
| // Initialize a new temporary buffer. | ||
| tmpBuffer := new(bytes.Buffer) | ||
| size, err = hashCopyN(hashAlgos, hashSums, tmpBuffer, reader, size) | ||
| if err != nil { |
There was a problem hiding this comment.
Actually, hashCopyN can return io.EOF in normal conditions (not sure why), besides, there is a check of err later.
There was a problem hiding this comment.
hashCopy should be io.Copy equivalent so should never return io.EOF
vadmeste
reviewed
Feb 17, 2017
api-put-object.go
Outdated
| @@ -205,10 +205,13 @@ func (c Client) putObjectSingle(bucketName, objectName string, reader io.Reader, | |||
| hashAlgos["sha256"] = sha256.New() | |||
| } | |||
|
|
|||
| if size <= minPartSize { | |||
| if size <= minPutBufferSize { | |||
There was a problem hiding this comment.
This was minPartSize, it means else was never entered, it could have buggy code.
There was a problem hiding this comment.
Actually let me revert this back its not needed with this patch.
harshavardhana
force-pushed
the
nop-closer
branch
3 times, most recently
from
c97bc52 to
d344199
Compare
This is needed since in go1.8 wrapping the body can cause content-length to be not calculated properly, which would lead to failures on the server side when uploading a zero byte object.
harshavardhana
force-pushed
the
nop-closer
branch
from
d344199 to
c07cfc4
Compare
vadmeste
added a commit
to vadmeste/minio-go
that referenced
this pull request
Mar 9, 2017
Partially revert minio#614
vadmeste
added a commit
to vadmeste/minio-go
that referenced
this pull request
Mar 9, 2017
Partially revert minio#614
vadmeste
added a commit
to vadmeste/minio-go
that referenced
this pull request
Mar 9, 2017
Partially revert minio#614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed since in go1.8 wrapping the body can cause
content-length to be not calculated properly, which would
lead to failures on the server side when uploading a zero
byte object.